Re: [PATCH v13 4/8] bisect: introduce support for --no-checkout option.

Jon Seymour [off-list ref] writes:

quoted

I think this is a regression from naming perspective from the previous
round. You would be either the normal (checkout) mode or no-checkout mode,
and honestly, --no-checkout would be understood by anybody while update-ref
would be understood only by Gitz.

Is it relevant here that --bisect-mode here is on bisect--helper which
is really part of the plumbing and unlikely to be used by anything
other than git's own porcelain?

Ah, Ok, that is what I missed. I also was scratching my head after seeing
that there was not much change in the proposed log messages from the
earlier round.

On Wed, Aug 3, 2011 at 8:05 AM, Junio C Hamano [off-list ref] wrote:

Jon Seymour [off-list ref] writes:

quoted

quoted

I think this is a regression from naming perspective from the previous
round. You would be either the normal (checkout) mode or no-checkout mode,
and honestly, --no-checkout would be understood by anybody while update-ref
would be understood only by Gitz.

Is it relevant here that --bisect-mode here is on bisect--helper which
is really part of the plumbing and unlikely to be used by anything
other than git's own porcelain?

Ah, Ok, that is what I missed. I also was scratching my head after seeing
that there was not much change in the proposed log messages from the
earlier round.

I've issued a v14 that removes it - I was treating it as a boolean in
the C code anyway.

If anything v14 git-bisect.sh is slightly simpler than v13

jon,