Re: [PATCH 06/14] introduce credentials API

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:38

Jeff King [off-list ref] writes:

quoted hunk

diff --git a/credential.c b/credential.c
new file mode 100644
index 0000000..c403289
--- /dev/null
+++ b/credential.c

@@ -0,0 +1,190 @@

...
+void credential_fill(struct credential *c, const struct string_list *methods)
+{
+	...
+	}
+	die(err.buf);

credential.c:195: error: format not a string literal and no format arguments

This needs to be

	die("%s", err.buf);

From: Jeff King <hidden>
Date: 2016-06-15 22:51:38

On Thu, Jul 21, 2011 at 02:59:31PM -0700, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

diff --git a/credential.c b/credential.c
new file mode 100644
index 0000000..c403289
--- /dev/null
+++ b/credential.c

@@ -0,0 +1,190 @@

...
+void credential_fill(struct credential *c, const struct string_list *methods)
+{
+	...
+	}
+	die(err.buf);

credential.c:195: error: format not a string literal and no format arguments

This needs to be

	die("%s", err.buf);

Thanks, silly me. I'm surprised I didn't get a warning, as I compile
with -Wall. Is there an extra flag you need to give gcc?

-Peff