Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:30

Andi Kleen [off-list ref] writes:
quoted
I would need to clarify with s/introduce noise/introduce more noise/; the
existing codebase is not noise-free.

But I do not see much point in making things worse, only to squelch
"reaches end of non void function" warnings that will be given under the
NO_NORETURN workaround configuration.
Can you please give specific guidance what I should do to make
the patchkit acceptable?
I am inclined to apply only 1 and 3, which is what I already have on 'pu'.

Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN

From: Andi Kleen <hidden>
Date: 2016-06-15 22:51:30

I am inclined to apply only 1 and 3, which is what I already have on 'pu'.
Thanks. 

I guess should add some documentation that explains that there
are additional warnings (and some general pointers). I'll send that
in another patch.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help