[PATCH] gitweb: 'pickaxe' feature requires...

[PATCH] gitweb: 'pickaxe' feature requires 'search' enabled

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:51:30

Signed-off-by: Jakub Narebski <redacted>
---
This is something I noticed when working on improving gitweb search.

 gitweb/gitweb.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9e6426..1a59781 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -342,6 +342,7 @@ our %feature = (
 	# Enable the pickaxe search, which will list the commits that modified
 	# a given string in a file. This can be practical and quite faster
 	# alternative to 'blame', but still potentially CPU-intensive.
+	# Note that you need to have 'search' feature enabled too.
 
 	# To enable system wide have in $GITWEB_CONFIG
 	# $feature{'pickaxe'}{'default'} = [1];

[PATCH (amend)] gitweb: 'pickaxe' and 'grep' features requires 'search' to be enabled

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:51:30

Both 'pickaxe' (searching changes) and 'grep' (searching files)
require basic 'search' feature to be enabled to work.  Enabling
e.g. only 'pickaxe' won't work.

Add a comment about this.

Signed-off-by: Jakub Narebski <redacted>
---
I'm sorry, I forgot that this issue applies to 'grep' feature too.

 gitweb/gitweb.perl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index c9e6426..63af8d4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl

@@ -328,6 +328,7 @@ our %feature = (
 	# Enable grep search, which will list the files in currently selected
 	# tree containing the given string. Enabled by default. This can be
 	# potentially CPU-intensive, of course.
+	# Note that you need to have 'search' feature enabled too.
 
 	# To enable system wide have in $GITWEB_CONFIG
 	# $feature{'grep'}{'default'} = [1];

@@ -342,6 +343,7 @@ our %feature = (
 	# Enable the pickaxe search, which will list the commits that modified
 	# a given string in a file. This can be practical and quite faster
 	# alternative to 'blame', but still potentially CPU-intensive.
+	# Note that you need to have 'search' feature enabled too.
 
 	# To enable system wide have in $GITWEB_CONFIG
 	# $feature{'pickaxe'}{'default'} = [1];

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help