Re: [PATCH 04/19] teach remote-testgit to import non-HEAD refs

Sverre Rabbelier [off-list ref] writes:

From: Jeff King <redacted>

Upon receiving an "import" command, the testgit remote
helper would ignore the ref asked for by git and generate a
fast-export stream based on HEAD. Instead, we should
actually give git the ref it asked for.

This requires adding a new parameter to the export_repo
method in the remote-helpers python library, which may be
used by code outside of git.git. We use a default parameter
so that callers without the new parameter will get the same
behavior as before.

Signed-off-by: Sverre Rabbelier <redacted>
---

  Unchanged from Peff's series.

This seems to be slightly different from what was sent to the list,
though.  Using refs=None as default and assigning ["HEAD"] is more in line
with the standard Python practice, so the implementation is better.

But "do we still append HEAD after --import-marks?" still stands.

Heya,

On Thu, Jun 9, 2011 at 01:48, Junio C Hamano [off-list ref] wrote:

This seems to be slightly different from what was sent to the list,
though.  Using refs=None as default and assigning ["HEAD"] is more in line
with the standard Python practice, so the implementation is better.

Ah, yes, I fixed the style nits suggested in my own review.

But "do we still append HEAD after --import-marks?" still stands.

Fixed locally. Sharp eyes :)

-- 
Cheers,

Sverre Rabbelier