Re: [PATCH v2 1/3] setup: Provide GIT_PREFIX to built-ins

David Aguilar [off-list ref] writes:

GIT_PREFIX was added in 7cf16a14f5c070f7b14cf28023769450133172ae so that
aliases can know the directory from which a !alias was called.

Knowing the prefix relative to the root is helpful in other programs
so export it to built-ins as well.

Signed-off-by: David Aguilar <redacted>
---

The original version of this patch did not set GIT_PREFIX
to an empty string when prefix returns NULL.
Now we do.

Thanks.  Should I add "Helped-by: MJG"?

On Thu, May 26, 2011 at 10:45:35AM -0700, Junio C Hamano wrote:

David Aguilar [off-list ref] writes:

quoted

GIT_PREFIX was added in 7cf16a14f5c070f7b14cf28023769450133172ae so that
aliases can know the directory from which a !alias was called.

Knowing the prefix relative to the root is helpful in other programs
so export it to built-ins as well.

Signed-off-by: David Aguilar <redacted>
---

The original version of this patch did not set GIT_PREFIX
to an empty string when prefix returns NULL.
Now we do.

Thanks.  Should I add "Helped-by: MJG"?

Yes, that'd be great.
-- 
					David