Re: [PATCH] Simple dead assignment

Chris Wilson [off-list ref] writes:

Oops, I see others putting the patches inline. Here you go.

Please, read Documentation/SubmittingPatches. Especially read about
signed-off-by and the way patches should be formatted (git send-email
would help).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

On Wed, May 25, 2011 at 09:52:56AM +0200, Matthieu Moy wrote:

Chris Wilson [off-list ref] writes:

quoted

Oops, I see others putting the patches inline. Here you go.

Please, read Documentation/SubmittingPatches. Especially read about
signed-off-by and the way patches should be formatted (git send-email
would help).

Thanks, trying this again. Like I said before, the author should
investigate if this variable should have been used before removing it.

Signed-off-by: Chris Wilson <redacted>
---
 sh-i18n--envsubst.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c
index 7125093..5829463 100644
--- a/sh-i18n--envsubst.c
+++ b/sh-i18n--envsubst.c

@@ -67,9 +67,6 @@ static void subst_from_stdin (void);
 int
 main (int argc, char *argv[])
 {
-  /* Default values for command line options.  */
-  unsigned short int show_variables = 0;
-
   switch (argc)
        {
        case 1:

@@ -88,7 +85,6 @@ main (int argc, char *argv[])
          /* git sh-i18n--envsubst --variables '$foo and $bar' */
          if (strcmp(argv[1], "--variables"))
                error ("first argument must be --variables when two are given");
-         show_variables = 1;
       print_variables (argv[2]);
          break;
        default:
--

1.7.5.2.354.g19aea

There already is a patch on its way:

http://article.gmane.org/gmane.comp.version-control.git/174378

The assignment to fmt is dead and is also useless.

Signed-off-by: Chris Wilson <redacted>
---

On Wed, May 25, 2011 at 07:18:57PM +0200, Michael Schubert wrote:

There already is a patch on its way:

http://article.gmane.org/gmane.comp.version-control.git/174378

Thanks! Well, I wasn't going to report this dead assignment since
it wasn't done recently, but now I want to figure out how to properly
submit a patch. :) Am I there yet? and thanks for the help.

Thanks,
CHris

 pretty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/pretty.c b/pretty.c
index dff5c8d..5667c7f 100644
--- a/pretty.c
+++ b/pretty.c

@@ -1082,7 +1082,6 @@ void userformat_find_requirements(const char *fmt, struct userformat_
        if (!fmt) {
                if (!user_format)
                        return;
-               fmt = user_format;
        }
        strbuf_expand(&dummy, user_format, userformat_want_item, w);
        strbuf_release(&dummy);

-- 
1.7.5.2.354.g19aea