Should I extract first two commits i.e.
- Remove gitweb/gitweb.cgi and other legacy targets from main Makefile
- git-instaweb: Simplify build dependency on gitweb
into a separate patch series? Even though their existence was
...
I think this cleanup is worthy on its own.
Sounds like a good idea. Thanks.
And here it is. I'm sorry for the delay.
Shortlog:
~~~~~~~~~
Jakub Narebski (2):
git-instaweb: Simplify build dependency on gitweb
Remove gitweb/gitweb.cgi and other legacy targets from main Makefile
Diffstat:
~~~~~~~~~
Makefile | 28 +---------------------------
1 files changed, 1 insertions(+), 27 deletions(-)
--
1.7.5
From: Jakub Narebski <hidden> Date: 2016-06-15 22:51:11
Since c0cb4ed (git-instaweb: Configure it to work with new gitweb
structure, 2010-05-28) git-instaweb does not re-create gitweb.cgi
etc., but makes use of installed gitweb. Therefore simplify
git-instaweb dependency on gitweb subsystem in main Makefile from
'gitweb/gitweb.cgi gitweb/static/gitweb.css gitweb/static/gitweb.js'
to simply 'gitweb'.
This is preparation for splitting gitweb.perl script, and for
splitting gitweb.js (to be reassembled / combined on build). This way
we don't have to duplicate parts of gitweb/Makefile in main
Makefile... it is also more correct description of git-instaweb
dependency.
Reported-by: Junio C Hamano <redacted>
Signed-off-by: Jakub Narebski <redacted>
---
This patch is part of 'jn/gitweb-js' (a76424e) in 'pu', and was sent
to git mailing list as part of the following series:
[PATCHv3 00/13] gitweb: Change timezone in dates using JavaScript
http://thread.gmane.org/gmane.comp.version-control.git/172384
I think this simplification of git-instaweb dependencies is worth on
its own, even if gitweb.js won't be generated file.
P.S. Now that it is standalone, Reported-by makes little sense, though...
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Jakub Narebski <hidden> Date: 2016-06-15 22:51:11
Now that there is gitweb/Makefile, let's leave only "gitweb" and
"install-gitweb" targets in main Makefile. Those targets just
delegate to gitweb's Makefile.
Requested-by: Junio C Hamano [off-list ref]
Signed-off-by: Jakub Narebski <redacted>
---
This patch is part of 'jn/gitweb-js' (a76424e) in 'pu', and was sent
to git mailing list as part of the following series:
[PATCHv3 00/13] gitweb: Change timezone in dates using JavaScript
http://thread.gmane.org/gmane.comp.version-control.git/172384
I think this simplification (straighforward deletion of duplicated
code) is worth on its own.
Makefile | 26 --------------------------
1 files changed, 0 insertions(+), 26 deletions(-)