DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH] gitweb: supply '-n' to gzip for identical output

From: Fraser Tweedale <hidden>
Date: 2016-06-15 22:51:05
Subsystem: the rest · Maintainer: Linus Torvalds

Without the '-n' ('--no-name') argument, gzip includes a timestamp in
output which results in different files.  Important systems like FreeBSD
ports and perhaps several others hash/checksum downloaded files to ensure
integrity.  For projects that do not release official archives, gitweb's
snapshot feature would be an excellent alternative, except that the files
it produces are not identical.

Whilst '--no-name' is more descriptive, the long version of the flag is
not supported on all systems.  In particular, OpenBSD does not appear to
support it.

Supply '-n' to gzip to exclude timestamp from output and produce idential
output every time.

Signed-off-by: Fraser Tweedale <redacted>
Acked-by: Jakub Narebski <redacted>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ee69ea6..f8db40a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -186,7 +186,7 @@ our %known_snapshot_formats = (
 		'type' => 'application/x-gzip',
 		'suffix' => '.tar.gz',
 		'format' => 'tar',
-		'compressor' => ['gzip']},
+		'compressor' => ['gzip', '-n']},
 
 	'tbz2' => {
 		'display' => 'tar.bz2',
-- 
1.7.4.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help