Re: [PULL svn-fe] vcs-svn: simplifications, error handling improvements

Junio C Hamano [off-list ref] writes:

By the way, I've been getting annoyed by these three "sleep 100" getting
stuck in t0081 and spending their sweet timeout while running my tests
(prove is on, "make test </dev/null" to forbid it from reading my stdin).
I see attempts to kill them early with "kill $!" but apparently they are
not working. Can you take a look at it?

A bit more datapoint.  The first one works just fine, while the second one
gets stuck:

    $ cd t && make T=t0081-line-buffer.sh test
    $ cd t && make T=t0081-line-buffer.sh prove

I notice that [sh] spawned from prove is orphaned.

21643 pts/9    Ss     0:00      \_ bash
17149 pts/9    S+     0:00      |   \_ make T=t0081-line-buffer.sh prove
17155 pts/9    S+     0:00      |       \_ /bin/sh -c echo "*** prove ***"; GIT_CONFIG=.git/
17156 pts/9    S+     0:00      |           \_ /usr/bin/perl /usr/bin/prove --exec /bin/sh t
17157 pts/9    Z+     0:00      |               \_ [sh] <defunct>

Is this a known bug in prove perhaps?

    $ /usr/bin/prove --version
    TAP::Harness v3.17 and Perl v5.10.1

Junio C Hamano wrote:

A bit more datapoint.  The first one works just fine, while the second one
gets stuck:

    $ cd t && make T=t0081-line-buffer.sh test
    $ cd t && make T=t0081-line-buffer.sh prove

I notice that [sh] spawned from prove is orphaned.

21643 pts/9    Ss     0:00      \_ bash
17149 pts/9    S+     0:00      |   \_ make T=t0081-line-buffer.sh prove
17155 pts/9    S+     0:00      |       \_ /bin/sh -c echo "*** prove ***"; GIT_CONFIG=.git/
17156 pts/9    S+     0:00      |           \_ /usr/bin/perl /usr/bin/prove --exec /bin/sh t
17157 pts/9    Z+     0:00      |               \_ [sh] <defunct>

Hmm, looks like the "kill $!" is not working like it is supposed to.
What is your /bin/sh?  How far does

	make T=0081-line-buffer.sh prove SHELL_PATH_SH='/bin/sh -x'

get before the lull?

Jonathan Nieder wrote:

What is your /bin/sh?

Looks like

	prove --exec=bash t0081-line-buffer.sh

is enough to reproduce this, while

	bash t0081-line-buffer.sh

works fine.  And it seems to be racy --- with prove, sometimes the
first test hangs, sometimes the 13th, sometimes none.  Sadly that's
all there's time for tonight.

Thanks for catching it.

Puzzled,
Jonathan