Re: [PATCH 4/8] vcs-svn: remove spurious semicolons

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 4/8] vcs-svn: remove spurious semicolons

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:50:47

Jonathan Nieder [off-list ref] writes:
quoted hunk
trp_gen is not a statement or function call, so it should not be
followed with a semicolon.  Noticed by gcc -pedantic.

 vcs-svn/repo_tree.c:41:81: warning: ISO C does not allow extra ';'
  outside of a function [-pedantic]
...
diff --git a/vcs-svn/repo_tree.c b/vcs-svn/repo_tree.c
index 491f013..207ffc3 100644
--- a/vcs-svn/repo_tree.c
+++ b/vcs-svn/repo_tree.c
@@ -38,7 +38,7 @@ static uint32_t mark;
 static int repo_dirent_name_cmp(const void *a, const void *b);
 
 /* Treap for directory entries */
-trp_gen(static, dent_, struct repo_dirent, children, dent, repo_dirent_name_cmp);
+trp_gen(static, dent_, struct repo_dirent, children, dent, repo_dirent_name_cmp)
Yuck.  Correct but ugly.

Re: [PATCH 4/8] vcs-svn: remove spurious semicolons

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:50:47

Junio C Hamano wrote:
Yuck.  Correct but ugly.
Yes, might be better for me to just hurry and apply David's patches to
get rid of the treap. :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help