Re: What's cooking in git.git (Feb 2011, #05; Wed, 23)

Ævar Arnfjörð Bjarmason [off-list ref] writes:

Right, once we're confident (which at least I am) that the first few
patches really are no-op's I think it would be easier for everyone to
merge them down sooner than later.

We three are pretty much on the same page, then.

Two minor points are what to do with the "#" prefix in "# POISON #" and
namespace contamination, but other than these I don't think there is
anything controversial.

quoted

quoted

    Warning: you are leaving 1 commit behind that are not connected to
    any of your branches:

For the singular this should be "1 commit behind which is not
corrected to any of your branches".

Heh, thanks.  I would think "s/ that are /, /" would fix it rather
nicely.

s/corrected/connected/ also :)

That typo appears only in _your_ version, not mine ;-).

On Thu, Feb 24, 2011 at 02:59, Junio C Hamano [off-list ref] wrote:

Ævar Arnfjörð Bjarmason [off-list ref] writes:

quoted

Right, once we're confident (which at least I am) that the first few
patches really are no-op's I think it would be easier for everyone to
merge them down sooner than later.

We three are pretty much on the same page, then.

Two minor points are what to do with the "#" prefix in "# POISON #"

The root cause of this is solved in a patch by Jonathan:

    https://github.com/avar/git/commit/da15d84430e5f9b68125f6ddad61f66251c991ac

I thought it was better to submit it later once this was in. The
current behavior is harmless hack that we're aware of.

namespace contamination,

You mean just _ being propagated everywhere? That seems harmless.

but other than these I don't think there is anything controversial.

Great.

quoted

s/corrected/connected/ also :)

That typo appears only in _your_ version, not mine ;-).

Indeed. I was amending my suggestion, not your original :)