Nicolas Pitre [off-list ref] writes:
On Mon, 31 Jan 2011, Jeff King wrote:
quoted
Besides being just one more directory to go up and down, it does make
history browsing more annoying. As much as I love git's "don't record
renames" philosophy, our handling of renames on the viewing side is
often annoying. I already get annoyed sometimes following stuff across
the s!builtin-!builtin/! change. This would be like that but more so.
So... we do suck at something? So why not take this opportunity to
shake yourself out of this easy comfort and improve Git as a result on
both front? :-)
quoted
Or maybe it is a good thing for that reason, as we will eat our own
rename dogfood. :)
Exactly! And maybe we'll make Git even more useful in the process.
This part I _could_ actually buy; even though I do not think moving files
without much reason is a good project hygine, it does happen in real life,
and we would want to keep things smooth for real people.
quoted
quoted
5) Rename t/ to testsuite/ so this doesn't look like some garbage
leftover.
I am not sure about this "t/" vs "testsuite/".
quoted
Ugh, more typing. :P
Come on! You sound like an old fart now! ;-)
If we make the top-level directory lean enough, we probably can tab
complete after typing just "cd t" to go to testsuite/ or tests/ or
whatever you come up with, so "more typing" is not a huge issue to me
personally.
I however think the directory name "t/" is not our invention but what we
took from somebody else (perhaps Perl?), and I suspect some people expect
to find tests under there since we have had them there for a long time.
I think a good code hygiene is important, and some suggestions here
are relevant:
1) I also think there should be a directory for the source code
(namely, src/), and the top level should act as a table of contents.
As a newcomer myself who's trying to grasp Git, I can say an organized
project makes people more inclined join. Therefore, directories should
be named as clearly as possible: see item 2;
2) For item 1, t/ should be renamed to testsuite/. As Junio said, if
we get a more organized project, people could just "cd t" and tab to
autocomplete, or "cd tes" at the worst scenario, which is not such a
big hassle. About people expecting the testsuite to be inside t/, once
they type "cd t" and get an error, most people would look for an
alternative and eventually find the correct folder, or tabbing would
just suggest the name.
3) The top level should hold files that point people towards where
they want to go, helpful files like README and even some
Documentation/ files could get a promotion.
3) As 1.8.0 can be an inflexion for users, so could be for the
developers as well.
--
João Paulo Melo de Sampaio
Computer Engineering Student @ UFSCar
Website: http://www.jpmelos.com
Twitter: twitter.com/jpmelos (@jpmelos)
On Mon, 31 Jan 2011, Junio C Hamano wrote:
If we make the top-level directory lean enough, we probably can tab
complete after typing just "cd t" to go to testsuite/ or tests/ or
whatever you come up with, so "more typing" is not a huge issue to me
personally.
I however think the directory name "t/" is not our invention but what we
took from somebody else (perhaps Perl?), and I suspect some people expect
to find tests under there since we have had them there for a long time.
If those people are not able to figure out that "testsuite" means where
tests are, especially within a lean top directory, then we might
question the reliability of the tests they might contribute.
Nicolas