Re: [PATCH 3/3] get_sha1: support ref^{/regex} syntax

Nguyễn Thái Ngọc Duy  [off-list ref] writes:

+test_expect_success 'ref^{/}' '
+	git rev-parse master >expected &&
+	git rev-parse master^{/} >actual &&
+	test_cmp expected actual
+'

This test fails on FBSD 8, which refuses to regcomp("")
saying "empty (sub)expression", which is somewhat bogus.

I'd change it to "/." for now ;-).

2010/12/15 Junio C Hamano [off-list ref]:

Nguyễn Thái Ngọc Duy  [off-list ref] writes:

quoted

+test_expect_success 'ref^{/}' '
+     git rev-parse master >expected &&
+     git rev-parse master^{/} >actual &&
+     test_cmp expected actual
+'

This test fails on FBSD 8, which refuses to regcomp("")
saying "empty (sub)expression", which is somewhat bogus.

I'd change it to "/." for now ;-).

Perhaps we should just reject this case. No sane body would ever use it.
-- 
Duy