DORMANTno replies

[PATCH] transport-helper: avoid dependency on thread-utils.h

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:50:13
Subsystem: the rest · Maintainer: Linus Torvalds

Since the transport-helper does not use recursive mutexes or ask the
number of cores, it does not require any declarations from the
thread-utils lib.  Removing the unnecessary #include avoids false
positives from "make CHECK_HEADER_DEPENDENCIES=1".

Signed-off-by: Jonathan Nieder <redacted>
---
The #include directive in question was added in 7851b1e60
(remote-fd/ext: finishing touches after code review, 2010-11-17),
at the same times as the necessary #include for <pthread.h>.
This patch seems to work for me, but I wouldn't be surprised if
to be missing something.

 transport-helper.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 3a50856..7c99051 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -11,7 +11,6 @@
 
 #ifndef NO_PTHREADS
 #include <pthread.h>
-#include "thread-utils.h"
 #endif
 
 static int debug;
-- 
1.7.2.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help