[PATCH] t9143: do not fail when unhandled.log.gz is not created

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] t9143: do not fail when unhandled.log.gz is not created

From: Torsten Bögershausen <hidden>
Date: 2016-06-15 22:50:13

Do not depend on internal implementation details of svn,
which right now uses perl to create a .gz file.
So this test case will even work in the future,
when svn changes its implementation.

Signed-off-by: Torsten Bögershausen <redacted>
---
  t/t9143-git-svn-gc.sh |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/t/t9143-git-svn-gc.sh b/t/t9143-git-svn-gc.sh
index 337ea59..4594e1a 100755
--- a/t/t9143-git-svn-gc.sh
+++ b/t/t9143-git-svn-gc.sh
@@ -37,13 +37,11 @@ test_expect_success 'git svn gc runs' 'git svn gc'
   test_expect_success 'git svn index removed' '! test -f 
.git/svn/refs/remotes/git-svn/index'
  -if perl -MCompress::Zlib -e 0 2>/dev/null
+if test -r .git/svn/refs/remotes/git-svn/unhandled.log.gz
  then
  	test_expect_success 'git svn gc produces a valid gzip file' '
  		 gunzip .git/svn/refs/remotes/git-svn/unhandled.log.gz
  		'
-else
-	say "# Perl Compress::Zlib unavailable, skipping gunzip test"
  fi
   test_expect_success 'git svn gc does not change unhandled.log files' '
-- 
1.6.6

Re: [PATCH] t9143: do not fail when unhandled.log.gz is not created

From: Eric Wong <hidden>
Date: 2016-06-15 22:50:13

Torsten Bögershausen [off-list ref] wrote:
Do not depend on internal implementation details of svn,
which right now uses perl to create a .gz file.
So this test case will even work in the future,
when svn changes its implementation.

Signed-off-by: Torsten Bögershausen <redacted>
Thanks Torsten, I needed to fix whitespace mangling from
your mailer to get it to apply cleanly.

Acked-by: Eric Wong <redacted>

It's pushed out to git://git.bogomips.org/git-svn along with an
older patch from Steven:

Steven Walter (1):
      git-svn: allow the mergeinfo property to be set

Torsten Bögershausen (1):
      t9143: do not fail when unhandled.log.gz is not created

-- 
Eric Wong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help