[PATCH] Match lightweight tags too in bash prompt

From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001

From: Daniel Knittl-Frank <redacted>
Date: Fri, 19 Nov 2010 16:40:02 +0100
Subject: [PATCH] Match lightweight tags too in bash prompt

provide `--tags` to git describe
---

bash prompt would display a commit's sha1, when checking out a lightweight tag.
provide --tags to git describe in the completion script, so it will
display the name
of the tag (as it already does for annotated tags)

 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/completion/git-completion.bash

b/contrib/completion/git-completion.bash
index f710469..604fa79 100755

--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash

@@ -261,7 +261,7 @@ __git_ps1 ()
 				(describe)
 					git describe HEAD ;;
 				(* | default)
-					git describe --exact-match HEAD ;;
+					git describe --tags --exact-match HEAD ;;
 				esac 2>/dev/null)" ||

 				b="$(cut -c1-7 "$g/HEAD" 2>/dev/null)..." ||

-- 
1.7.3.2.334.gd1031


-- 
typed with http://neo-layout.org
myFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!

On Fri, Nov 19, 2010 at 7:43 AM, knittl [off-list ref] wrote:

From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
From: Daniel Knittl-Frank <redacted>
Date: Fri, 19 Nov 2010 16:40:02 +0100
Subject: [PATCH] Match lightweight tags too in bash prompt

provide `--tags` to git describe

Missing signed-off-by-line.

---

bash prompt would display a commit's sha1, when checking out a lightweight tag.
provide --tags to git describe in the completion script, so it will
display the name
of the tag (as it already does for annotated tags)

This information is useful justification for the change.  It should
therefore appear in the commit message, above the --- line.

-- 
Shawn.

On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce [off-list ref] wrote:

On Fri, Nov 19, 2010 at 7:43 AM, knittl [off-list ref] wrote:

quoted

From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
From: Daniel Knittl-Frank <redacted>
Date: Fri, 19 Nov 2010 16:40:02 +0100
Subject: [PATCH] Match lightweight tags too in bash prompt

provide `--tags` to git describe

Missing signed-off-by-line.

i mentioned the s-o-b line already in my forward-mail ;)

quoted

---

bash prompt would display a commit's sha1, when checking out a lightweight tag.
provide --tags to git describe in the completion script, so it will
display the name
of the tag (as it already does for annotated tags)

This information is useful justification for the change.  It should
therefore appear in the commit message, above the --- line.

ok, i'll resend v2 tomorrow morning to you and the mailing list


cheers, daniel

-- 
typed with http://neo-layout.org
myFtPhp -- visit http://myftphp.sf.net -- v. 0.4.7 released!

On Tue, Nov 30, 2010 at 9:16 PM, knittl [off-list ref] wrote:

On Tue, Nov 30, 2010 at 7:04 PM, Shawn Pearce [off-list ref] wrote:

quoted

On Fri, Nov 19, 2010 at 7:43 AM, knittl [off-list ref] wrote:

quoted

From 1fea30e0167681917b4f40a3cb2cde9a90706011 Mon Sep 17 00:00:00 2001
From: Daniel Knittl-Frank <redacted>
Date: Fri, 19 Nov 2010 16:40:02 +0100
Subject: [PATCH] Match lightweight tags too in bash prompt

provide `--tags` to git describe

Missing signed-off-by-line.

i mentioned the s-o-b line already in my forward-mail ;)

I don't see it. You mean the From: line? If yes, that is not the
convention used here.

You have to add a line:
Signed-off-by: Your Name <redacted>

Take a look at Documentation/SubmittingPatches