[PATCH] gitk: Prevent the text pane from becoming editable

Subsystems: the rest

STALE3730d

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] gitk: Prevent the text pane from becoming editable

From: Stefan Haller <hidden>
Date: 2016-06-15 22:50:02

From: Stefan Haller <redacted>

When setting the "Patch/Tree" radio buttons to "Tree" and
clicking on a file to display it, the text pane would
accidentally become editable (because of the early return
in getblobline).

Signed-off-by: Stefan Haller <redacted>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 45e3380..260be1b 100755
--- a/gitk
+++ b/gitk
@@ -7303,6 +7303,7 @@ proc getblobline {bf id} {
 			    [lindex [split $commentend .] 0]}]
 	    mark_ctext_line $lnum
 	}
+	$ctext config -state disabled
 	return 0
     }
     $ctext config -state disabled
-- 
1.7.3.2.154.gcfae0

Re: [PATCH] gitk: Prevent the text pane from becoming editable

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:50:14

On Sun, Nov 14, 2010 at 01:21:50PM +0100, Stefan Haller wrote:
From: Stefan Haller <redacted>

When setting the "Patch/Tree" radio buttons to "Tree" and
clicking on a file to display it, the text pane would
accidentally become editable (because of the early return
in getblobline).
Thanks, applied.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help