Thiago Farina [off-list ref] writes:
On Sat, Oct 23, 2010 at 11:33 AM, Yann Dirson [off-list ref] wrote:
quoted
static const char builtin_diff_usage[] =
-"git diff <options> <rev>{0,2} -- <path>*";
+"git diff [<common diff options>] <commit>{0,2} -- <path>*"
Why change from <options> to <common diff options> ?
Because this is what the man page says I guess.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
On Sat, Oct 23, 2010 at 08:04:26PM +0200, Matthieu Moy wrote:
Thiago Farina [off-list ref] writes:
quoted
On Sat, Oct 23, 2010 at 11:33 AM, Yann Dirson [off-list ref] wrote:
quoted
static const char builtin_diff_usage[] =
-"git diff <options> <rev>{0,2} -- <path>*";
+"git diff [<common diff options>] <commit>{0,2} -- <path>*"
Why change from <options> to <common diff options> ?
Because this is what the man page says I guess.
Yes, as well as the usage strings for diff-tree, diff-files, and
diff-index. "diff" was just the only one to be different here, and if
we want to keep "<options>" for conciseness here, we also probably
want to change it everywhere (or maybe "<diff options>" for the diff-*
commands ?) - after all, this is just a short usage string, not the
reference page.