[PATCH] t/t7300: workaround ancient touch by rearranging arguments

From: Brandon Casey <redacted>

The ancient touch on Solaris 7 thinks that a decimal number supplied as
the first argument specifies a date_time to give to the files specified by
the remaining arguments.  In this case, it fails to parse '1' as a proper
date_time and exits with a failure status.  Workaround this flaw by
rearranging the arguments supplied to touch so that a non-digit appears
first and touch will not be confused.

Signed-off-by: Brandon Casey <redacted>
---
 t/t7300-clean.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh
index 7dbbea1..6c776e9 100755
--- a/t/t7300-clean.sh
+++ b/t/t7300-clean.sh

@@ -443,7 +443,7 @@ test_expect_success 'git clean -e' '
 	(
 		cd repo &&
 		git init &&
-		touch 1 2 3 known &&
+		touch known 1 2 3 &&
 		git add known &&
 		git clean -f -e 1 -e 2 &&
 		test -e 1 &&

-- 
1.7.2.1

On Wed, Sep 15, 2010 at 03:58:22PM -0500, Brandon Casey wrote:

From: Brandon Casey <redacted>

The ancient touch on Solaris 7 thinks that a decimal number supplied as
the first argument specifies a date_time to give to the files specified by
the remaining arguments.  In this case, it fails to parse '1' as a proper
date_time and exits with a failure status.  Workaround this flaw by
rearranging the arguments supplied to touch so that a non-digit appears
first and touch will not be confused.

Hmm, this seemed eerily familiar, and sure enough:

  http://article.gmane.org/gmane.comp.version-control.git/101270

I don't _think_ I had Solaris 7 anytime recently, so the issue may be
even more widespread (I would guess that my patch was a result of
Solaris 8). Anyway, good catch.

-Peff

Heya,

On Thu, Sep 16, 2010 at 02:31, Jeff King [off-list ref] wrote:

Hmm, this seemed eerily familiar, and sure enough:

 http://article.gmane.org/gmane.comp.version-control.git/101270

Does this call for a git_touch which does a regular 'touch' for each
of its arguments?

-- 
Cheers,

Sverre Rabbelier

On Sat, Sep 18, 2010 at 01:26:25AM +0200, Sverre Rabbelier wrote:

On Thu, Sep 16, 2010 at 02:31, Jeff King [off-list ref] wrote:

quoted

Hmm, this seemed eerily familiar, and sure enough:

 http://article.gmane.org/gmane.comp.version-control.git/101270

Does this call for a git_touch which does a regular 'touch' for each
of its arguments?

I don't know the broken touch's behavior, and I don't have it handy. It
might handle "touch 1" fine or it might interpret it as "touch at time
1, no file arguments". Brandon's solution is good enough for a test
script.

If you really wanted a portable git_touch, you would spell it ">>$file".

-Peff