Re: [PATCH] builtin/describe.c: ignore untracked changes in submodules

Jens Lehmann [off-list ref] writes:

quoted

So if I didn't misunderstand something here I would rather vote against this change,
git describe should append a '-dirty' when git status would show modifications, no?

And maybe we should teach "git describe" the "--ignore-submodules" option, then
you could tell describe what to pass to the diff-index command. Thoughts?

It is sensible to add the option, and handle_ignore_submodules_arg() call
to grab "diff.ignoresubmodules" configuration) to the command, perhaps.

Both "status" and "diff" are described in the documentation as having
"all" as the default value for --ignore-submodules option, but by default
neither ignores changes in the submodules.  So it seems consistent for the
command to take submodule changes into account by default.

Jens Lehmann [off-list ref] writes:

quoted

And maybe we should teach "git describe" the "--ignore-submodules" option, then
you could tell describe what to pass to the diff-index command. Thoughts?

It is sensible to add the option, and handle_ignore_submodules_arg() call
to grab "diff.ignoresubmodules" configuration) to the command, perhaps.

Ok, I'll look into that and prepare a patch.