The --no-python option was added to test-lib.sh by Johannes Schindelin
in early 2006 in abb7c7b3. It was later turned into a no-op by Junio C
Hamano in 7cdbff14 the same year.
Over three years is long enough before removing this old wart which
was retained for backwards compatibility. Our tests have been using
NO_PYTHON and "test_have_prereq PYTHON" for a long time now.
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
t/test-lib.sh | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index e5523dd..e151da6 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -132,9 +132,6 @@ do
with_dashes=t; shift ;;
--no-color)
color=; shift ;;
- --no-python)
- # noop now...
- shift ;;
--va|--val|--valg|--valgr|--valgri|--valgrin|--valgrind)
valgrind=t; verbose=t; shift ;;
--tee)
--
1.7.1
On Sat, Jul 31, 2010 at 16:49, Ævar Arnfjörð Bjarmason [off-list ref] wrote:
The --no-python option was added to test-lib.sh by Johannes Schindelin
in early 2006 in abb7c7b3. It was later turned into a no-op by Junio C
Hamano in 7cdbff14 the same year.
Sorry for the resend. git-send-email was hanging and I thought the
original didn't go through:
Subject: [PATCH] test-lib: Remove 3 year old no-op --no-python option
Date: Sat, 31 Jul 2010 16:49:18 +0000
Message-Id: [off-list ref]
X-Mailer: git-send-email 1.7.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
Password:
^C
stty: standard input: Input/output error
But evidently that went through, here's the output from the second
one:
Send this email? ([y]es|[n]o|[q]uit|[a]ll): y
Password:
OK. Log says:
Server: smtp.gmail.com
MAIL FROM:[off-list ref]
RCPT TO:[off-list ref]
RCPT TO:[off-list ref]
RCPT TO:[off-list ref]
From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?=
[off-list ref]
To: git@vger.kernel.org
Cc: Junio C Hamano [off-list ref],
=?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?=
[off-list ref]
Subject: [PATCH] test-lib: Remove 3 year old no-op --no-python option
Date: Sat, 31 Jul 2010 16:49:53 +0000
Message-Id: [off-list ref]
X-Mailer: git-send-email 1.7.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Result: 250 2.0.0 OK 1280595002 j1sm1835091wej.39
Perhaps git-send-email should indicate that it has aquired a
connection to the server?