[PATCH] checkout: add a test for creating a new branch with regexp as a starting point

Reported-by: Ivan Zakharyaschev <redacted>
Signed-off-by: Dmitry V. Levin <redacted>
---

This is just a regression test for the bug.

 t/t2018-checkout-new-branch-by-regexp.sh |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100755 t/t2018-checkout-new-branch-by-regexp.sh

diff --git a/t/t2018-checkout-new-branch-by-regexp.sh b/t/t2018-checkout-new-branch-by-regexp.sh
new file mode 100755
index 0000000..78e54c5
--- /dev/null
+++ b/t/t2018-checkout-new-branch-by-regexp.sh

@@ -0,0 +1,22 @@
+#!/bin/sh
+
+test_description='checkout -b new_branch :/regexp'
+
+. ./test-lib.sh
+
+test_expect_success setup '
+	echo a > a &&
+	git add a &&
+	test_tick &&
+	git commit -m first &&
+	echo b > b &&
+	git add b &&
+	test_tick &&
+	git commit -m second
+'
+
+test_expect_success checkout '
+	git checkout -b new_branch :/first
+'
+
+test_done

-- 
ldv

On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin [off-list ref] wrote:

Reported-by: Ivan Zakharyaschev <redacted>
Signed-off-by: Dmitry V. Levin <redacted>
---

This is just a regression test for the bug.

Thanks, always good to have more tests.

This should use test_commit (see t/README), but...

+test_expect_success checkout '
+       git checkout -b new_branch :/first
+'
+
+test_done

...it looks like this can just be added to the end of
t2018-checkout-branch.sh instead of creating a new test. Creating a
new file just for a single test for such a simple feature is a bit of
an overkill.

Ævar Arnfjörð Bjarmason wrote:

On Thu, Jul 29, 2010 at 22:01, Dmitry V. Levin [off-list ref] wrote:

quoted

+test_expect_success checkout '
+       git checkout -b new_branch :/first
+'
+
+test_done

...it looks like this can just be added to the end of
t2018-checkout-branch.sh instead of creating a new test. Creating a
new file just for a single test for such a simple feature is a bit of
an overkill.

It should also use test_expect_failure unless you expect to have a fix
soon, otherwise it would stop the test suite from running through.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch