On 7/25/2010 7:35 PM, Jakub Narebski wrote:
BTW. is this something _you_ needed (and what did you need to configure
/ to put in $GITWEB_CONFIG file), or just a generalization?
This is something I was using in previous versions of gitweb, though
with the older (pre-592ea41) syntax. (I had applied the older
highlighting patches, and was quite happy to see them merged.)
Before, $GITWEB_CONFIG contained lines like:
$highlight_type{'\.lisp$'} = 'lisp';
As of 1.7.2, with syntax highlighting merged and refactored (592ea41),
access to the hashes that define syntax highlighting mappings was lost.
Moving the hashes out into the config area lets $GITWEB_CONFIG contain
lines like:
$highlight_ext{'lisp'} = 'lisp';
$highlight_basename{'GNUmakefile'} = 'mak'
On Mon, 26 Jul 2010, Alejandro R. Sedeño wrote:
On 7/25/2010 7:35 PM, Jakub Narębski wrote:
quoted
BTW. is this something _you_ needed (and what did you need to configure
/ to put in $GITWEB_CONFIG file), or just a generalization?
This is something I was using in previous versions of gitweb, though
with the older (pre-592ea41) syntax. (I had applied the older
highlighting patches, and was quite happy to see them merged.)
Before, $GITWEB_CONFIG contained lines like:
$highlight_type{'\.lisp$'} = 'lisp';
As of 1.7.2, with syntax highlighting merged and refactored (592ea41),
access to the hashes that define syntax highlighting mappings was lost.
Moving the hashes out into the config area lets $GITWEB_CONFIG contain
lines like:
$highlight_ext{'lisp'} = 'lisp';
$highlight_basename{'GNUmakefile'} = 'mak';
O.K., I don't think we want to put all possible languages that 'highlight'
supports in %highlight_ext, so you might want to add support for less
common languages, or languages introduced in newer versions of tool.
Note that you can write here
$highlight_basename{'GNUmakefile'} = 'make';
which might be slightly more readable.
--
Jakub Narebski
Poland
On 7/26/2010 4:48 PM, Jakub Narebski wrote:
quoted
As of 1.7.2, with syntax highlighting merged and refactored (592ea41),
quoted
access to the hashes that define syntax highlighting mappings was lost.
Moving the hashes out into the config area lets $GITWEB_CONFIG contain
lines like:
$highlight_ext{'lisp'} = 'lisp';
$highlight_basename{'GNUmakefile'} = 'mak';
O.K., I don't think we want to put all possible languages that 'highlight'
supports in %highlight_ext, so you might want to add support for less
common languages, or languages introduced in newer versions of tool.
Note that you can write here
$highlight_basename{'GNUmakefile'} = 'make';
which might be slightly more readable.
Yeah, that was a typo on my part; I was recalling samples from memory.
The actual entry reads 'make' not 'mak', just as you suggest. :)
-Alejandro