Re: [PATCH v2] Re: use "up-to-date" instead of "uptodate" for consistency

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2] Re: use "up-to-date" instead of "uptodate" for consistency

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:49:05

Nicolas Sebrecht [off-list ref] writes:
The 06/07/10, Junio C Hamano wrote:
quoted
Nicolas Sebrecht [off-list ref] writes:
quoted
@@ -22,7 +22,7 @@ static struct unpack_trees_error_msgs unpack_plumbing_errors = {
What word do you see before "errors" on the hunk comment line?
So you'd rather not touching it?
Well, "'d rather" is actually too weak a statement.

The "struct unpack_trees_error_msgs" mechanism was introduced so that we
can change the Porcelain level messages without breaking the plumbing API,
which these messages are part of.  Please see 8ccba00 (unpack-trees: allow
Porcelain to give different error messages, 2008-05-17) and fadd069
(merge-recursive: give less scary messages when merge did not start,
2009-09-07) for backstory.

[PATCH v3] merge-recursive: use "up-to-date" instead of "uptodate" in error message for consistency

From: Nicolas Sebrecht <hidden>
Date: 2016-06-15 22:49:05

Signed-off-by: Nicolas Sebrecht <redacted>
---

The 07/07/10, Junio C Hamano wrote:
The "struct unpack_trees_error_msgs" mechanism was introduced so that we
can change the Porcelain level messages without breaking the plumbing API,
which these messages are part of.  Please see 8ccba00 (unpack-trees: allow
Porcelain to give different error messages, 2008-05-17) and fadd069
(merge-recursive: give less scary messages when merge did not start,
2009-09-07) for backstory.
Oh, thanks. I was unaware of this mechanism and didn't care about what I was
touching.

 Documentation/git-checkout.txt |    2 +-
 merge-recursive.c              |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-checkout.txt b/Documentation/git-checkout.txt
index 261dd90..c04eceb 100644
--- a/Documentation/git-checkout.txt
+++ b/Documentation/git-checkout.txt
@@ -263,7 +263,7 @@ the above checkout would fail like this:
 +
 ------------
 $ git checkout mytopic
-fatal: Entry 'frotz' not uptodate. Cannot merge.
+fatal: Entry 'frotz' not up-to-date. Cannot merge.
 ------------
 +
 You can give the `-m` flag to the command, which would try a
diff --git a/merge-recursive.c b/merge-recursive.c
index 856e98c..fb6aa4a 100644
--- a/merge-recursive.c
+++ b/merge-recursive.c
@@ -1214,7 +1214,7 @@ int merge_trees(struct merge_options *o,
 	}
 
 	if (sha_eq(common->object.sha1, merge->object.sha1)) {
-		output(o, 0, "Already uptodate!");
+		output(o, 0, "Already up-to-date!");
 		*result = head;
 		return 1;
 	}
-- 
1.7.2.rc1.214.g95a9e
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help