Re: [PATCH 2/5] refs: split log_ref_write logic into log_ref_setup

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/5] refs: split log_ref_write logic into log_ref_setup

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:54

Erick Mattos [off-list ref] writes:
Now just a question, Junio:

I forgot to sign-off those patches, should I have to send them again?
I would have appreciated a whole re-send while I was too distracted by
non-git stuff during the past few weeks, but now I am more or less settled
in, it's Ok to just send a separate "Signed-off-by:" like this one:

    http://article.gmane.org/gmane.comp.version-control.git/148230/raw

Re: [PATCH 2/5] refs: split log_ref_write logic into log_ref_setup

From: Erick Mattos <hidden>
Date: 2016-06-15 22:48:54

Hi,

2010/6/2 Junio C Hamano [off-list ref]:
Erick Mattos [off-list ref] writes:
quoted
Now just a question, Junio:

I forgot to sign-off those patches, should I have to send them again?
I would have appreciated a whole re-send while I was too distracted by
non-git stuff during the past few weeks, but now I am more or less settled
in, it's Ok to just send a separate "Signed-off-by:" like this one:

   http://article.gmane.org/gmane.comp.version-control.git/148230/raw
All right, following then:

2010/5/21 Erick Mattos [off-list ref]:
These series of patches are improvements to 'git checkout --orphan'.

The main reason for them is a corner case which is not being solved by
actual implementation.  As it is a quite improbable situation and as it was
necessary to do more extensive changes to support it then its development
was held to be presented in a new developing cycle.

When someone set core.logAllRefUpdates to false reflogs are not created
automatically.  This behavior is superseeded by -l option.  Actually this is
not allowed with --orphan by current implementation.  Those new patches are
made to fix that.

There are also two other patches for configuring completion in bash and to
enhance documentation.

To be completely honest I don't see a point of not having the reflogs
created and deleted automatically so I see no reason for -l and
core.logAllRefUpdates at all.  But I do not like to do anything partially
thus these new patches.  If someone could show me a case please do it.  ;-)

[PATCH 1/5] Documentation: alter checkout --orphan description

This one improves documentation text by late corrections from previous
threads.

[PATCH 2/5] refs: split log_ref_write logic into log_ref_setup

Prepare the field by separating the logic to set up the reflog from the
reflog writing action.

[PATCH 3/5] checkout --orphan: respect -l option always

This is the actual actor.

[PATCH 4/5] t3200: test -l with core.logAllRefUpdates options

Adjusting scripts to test everything extensively.

[PATCH 5/5] bash completion: add --orphan to 'git checkout'

Just do that git change.
Signed-off-by: Erick Mattos <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help