[PATCH] git-svn: Remove unused use of File::Temp

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] git-svn: Remove unused use of File::Temp

From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2016-06-15 22:48:46

The use line was added in ffe256f9. File::Temp calls were later moved
to Git.pm in 0b19138b, but that commit neglected to remove the
now-redundant import.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
---
 git-svn.perl |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 2c86ea2..cc3a54c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3998,7 +3998,6 @@ use vars qw/@ISA/;
 use strict;
 use warnings;
 use Carp qw/croak/;
-use File::Temp qw/tempfile/;
 use IO::File qw//;
 use vars qw/$_ignore_regex/;
 
-- 
1.7.0.4

Re: [PATCH] git-svn: Remove unused use of File::Temp

From: Eric Wong <hidden>
Date: 2016-06-15 22:48:46

Ævar Arnfjörð Bjarmason [off-list ref] wrote:
The use line was added in ffe256f9. File::Temp calls were later moved
to Git.pm in 0b19138b, but that commit neglected to remove the
now-redundant import.

Signed-off-by: Ævar Arnfjörð Bjarmason <redacted>
Thanks,

Acked-by: Eric Wong <redacted>

...and pushed out to git://git.bogomips.org/git-svn along with a few
others:

Jonathan Nieder (1):
      git svn: avoid uninitialized var in 'reset'

Torsten Schmutzler (1):
      git-svn: mangle refnames forbidden in git

Ævar Arnfjörð Bjarmason (2):
      git-svn documentation: minor grammar fix
      git-svn: Remove unused use of File::Temp

-- 
Eric Wong
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help