Hello,
Just joined as I'm compiling git on a new platform and wondered if
someone can help solve a problem with the definition of S_IFGITLINK.
On my platform I have the following definitions....
#define __S_IFSOCK 0010000 /* Socket. */
#define __S_IFCHR 0020000 /* Character device. */
#define __S_IFDIR 0040000 /* Directory. */
#define __S_IFBLK 0060000 /* Block device. */
#define __S_IFREG 0100000 /* Regular file. */
#define __S_IFIFO 0120000 /* FIFO. */
#define __S_IFMEM 0140000 /* memory region or process */
#define __S_IFLNK 0160000 /* Symbolic link. */
Yet, S_IFGITLINK in the git sources is defined as 0160000, so this
clashes with my platform.
There is a comment about the definition of S_IFGITLINK in cache.h that
it shouldn't be used like this and should use internal values.
So I'm wondering if this can be fixed to remove this assumption ?
Additionally, attached is a patch that I currently need to apply in
order to compile git successfully on the FreeMiNT platform (which is
m68k based).
Comments appreciated.
Thanks,
Alan.
Hi,
Alan Hourihane wrote:
Additionally, attached is a patch that I currently need to apply in
order to compile git successfully on the FreeMiNT platform (which is
m68k based).
Comments appreciated.
While wiser people discuss the hard part, here are some tiny nitpicks. :)
quoted hunk
--- /dev/null 2008-12-07 20:01:52.000000000 +0000
+++ compat/mint.h 2008-12-23 11:52:10.000000000 +0000
@@ -0,0 +1,2 @@
+#define SA_RESTART 0
+#define ss_family sa_family
Does MiNT restart interrupted system calls by default? Are most
operations generally not interruptible anyway?
quoted hunk
--- Makefile 2009-01-29 12:12:01.000000000 +0000
+++ Makefile 2009-01-29 12:13:39.000000000 +0000
@@ -1618,7 +1613,7 @@
git-imap-send$X: imap-send.o $(GITLIBS)
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
- $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
+ $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
NEEDS_CRYPTO_WITH_SSL = YesPlease
[...]
git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
- $(LIBS) $(CURL_LIBCURL)
+ $(LIBS) $(CURL_LIBCURL) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
[...]
CURL_LIBCURL = -lcurl $(OPENSSL_LIBSSL)
Hope that helps,
Jonathan
On Tue, 2010-05-04 at 21:29 -0500, Jonathan Nieder wrote:
Hi,
Alan Hourihane wrote:
quoted
Additionally, attached is a patch that I currently need to apply in
order to compile git successfully on the FreeMiNT platform (which is
m68k based).
Comments appreciated.
While wiser people discuss the hard part, here are some tiny nitpicks. :)
quoted
--- /dev/null 2008-12-07 20:01:52.000000000 +0000
+++ compat/mint.h 2008-12-23 11:52:10.000000000 +0000
@@ -0,0 +1,2 @@
+#define SA_RESTART 0
+#define ss_family sa_family
Does MiNT restart interrupted system calls by default? Are most
operations generally not interruptible anyway?
Most operations are generally not interruptible.
quoted
--- Makefile 2009-01-29 12:12:01.000000000 +0000
+++ Makefile 2009-01-29 12:13:39.000000000 +0000
@@ -1618,7 +1613,7 @@
git-imap-send$X: imap-send.o $(GITLIBS)
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
- $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)
+ $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
NEEDS_CRYPTO_WITH_SSL = YesPlease
O.k.
[...]
quoted
git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
- $(LIBS) $(CURL_LIBCURL)
+ $(LIBS) $(CURL_LIBCURL) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)
[...]
CURL_LIBCURL = -lcurl $(OPENSSL_LIBSSL)
O.k.
Alan.