Re: [PATCH] .mailmap: Entries for Alex Bennée,Deskin Miller, Vitaly "_Vi" Shukela

Michael J Gruber [off-list ref] writes:

With the current .mailmap, git shortlog shows the following for these:

Thanks for doing the gruntwork; very much appreciated.

I'll backburner this and wait until the people who are described by these
entries say they want these entries in the .mailmap file.  If they do not
like the variant that your patch suggested, and if they care, then we will
get updates that should be applied.  Otherwise they themselves don't care,
so why should we ;-)?

On Sat, 20 Mar 2010, Junio C Hamano wrote:

Michael J Gruber [off-list ref] writes:

quoted

With the current .mailmap, git shortlog shows the following for these:

Thanks for doing the gruntwork; very much appreciated.

I'll backburner this and wait until the people who are described by these
entries say they want these entries in the .mailmap file.  If they do not
like the variant that your patch suggested, and if they care, then we will
get updates that should be applied.  Otherwise they themselves don't care,
so why should we ;-)?

I think at least one person (Michael) cared, so if the people described 
by those entries don't provide feedback then that means they don't care 
and you shouldn't wait after them to apply the patch including those 
entries.


Nicolas

Nicolas Pitre venit, vidit, dixit 20.03.2010 19:10:

On Sat, 20 Mar 2010, Junio C Hamano wrote:

quoted

Michael J Gruber [off-list ref] writes:

quoted

With the current .mailmap, git shortlog shows the following for these:

Thanks for doing the gruntwork; very much appreciated.

I'll backburner this and wait until the people who are described by these
entries say they want these entries in the .mailmap file.  If they do not
like the variant that your patch suggested, and if they care, then we will
get updates that should be applied.  Otherwise they themselves don't care,
so why should we ;-)?

I think at least one person (Michael) cared, so if the people described 
by those entries don't provide feedback then that means they don't care 
and you shouldn't wait after them to apply the patch including those 
entries.

Maybe I should have cc'ed Vitaly, the others are straight typo fixes.
(One may even argue that Vitaly's change is, too.) Smothering on the
backburner for a while, is fine, though ;)

I think for git.git it's simple enough to have "consistent" authorship
information, partly due to the scale, partly due to the fact that by
definition, submitters have a certain affluence with Git...

Also, if used without "-e", shortlog coalesces authors by full name. I
reckon this is the most common way it is used, and it's the mode for
which I provided cleanup.

If you distinguish by e-mail (-e) then there are many obvious multiple
entries, but it's not up to me to decide which is the main e-mail
address. One could take the latest one used, but some people distinguish
between work for hire (maybe for several employers) and private submissions.

Michael

so that git shortlog with '-e' coalesces all my commits.

Signed-off-by: Michael J Gruber <redacted>
---
 .mailmap |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/.mailmap b/.mailmap
index c507309..a8091eb 100644
--- a/.mailmap
+++ b/.mailmap

@@ -38,6 +38,7 @@ Li Hong <leehong@pku.edu.cn>
 Lukas Sandström <lukass@etek.chalmers.se>
 Martin Langhoff <martin@catalyst.net.nz>
 Michael Coleman <tutufan@gmail.com>
+Michael J Gruber <git@drmicha.warpmail.net> <michaeljgruber+gmane@fastmail.fm>
 Michael W. Olson <mwolson@gnu.org>
 Michele Ballabio <barra_cuda@katamail.com>
 Nanako Shiraishi <nanako3@bluebottle.com>

-- 
1.7.0.2.358.g30511

Michael J Gruber [off-list ref] writes:

Maybe I should have cc'ed Vitaly, the others are straight typo fixes.
(One may even argue that Vitaly's change is, too.) Smothering on the
backburner for a while, is fine, though ;)

Nico is right; what I wrote sounded that the patch will be forever on hold
until I get all three acks, but that wasn't my intention.

Also, if used without "-e", shortlog coalesces authors by full name. I
reckon this is the most common way it is used, and it's the mode for
which I provided cleanup.

If you distinguish by e-mail (-e) then there are many obvious multiple
entries, but it's not up to me to decide which is the main e-mail
address. One could take the latest one used, but some people distinguish
between work for hire (maybe for several employers) and private submissions.

True.

We might want to allow projects to use different mode of operation if they
so desire, though.  Linus Torvalds at OSDL and Linus Torvalds at L-F may
be one same person, and the person who is summarizing may want to
coallesce his commmits like this, even under "-e" option:

    Linus Torvalds [off-list ref],[off-list ref],[off-list ref] (1093):
      Initial revision of "git", the information manager from hell
      Add copyright notices.
      ... (many more commits) ...

while there may be more than one John Smiths that we can differenciate only
by email and they get their own separate group as different people (each
of them may have more than one email addresses).

If a grouping of set of name-mail pairs per individual is kept somewhere,
that can be used to enhance shortlog to support such a use case [*1*].
And the UUID thing could be one possible implementation (you make
name-mail pair to first map to some third identifier, and treat name-mail
pairs that map to the same identifier as "one person").  But I don't think
it would work well if you forced the maintenance burden of such a mapping
to individuals.


[Footnote]

*1* unless there is a situation where one person (say "Junio C Hamano")
stopped using one e-mail address (say "junkio@cox.net") s/he has been
using, and then a different person with the same name came and started
using the same address, that is.

On 20 March 2010 18:10, Nicolas Pitre [off-list ref] wrote:

On Sat, 20 Mar 2010, Junio C Hamano wrote:

quoted

Michael J Gruber [off-list ref] writes:

quoted

With the current .mailmap, git shortlog shows the following for these:

Thanks for doing the gruntwork; very much appreciated.

I'll backburner this and wait until the people who are described by these
entries say they want these entries in the .mailmap file.

I'm happy to have my name properly matched. I'm trying to keep my
repos where I do changes consistently configured with commit name and
email address but so far haven't managed it :-)

-- 
Alex, homepage: http://www.bennee.com/~alex/
http://www.half-llama.co.uk