Re: [PATCH 1/5] General configuration portability (Resend)

Hi Ben,

On Thu, Mar 11, 2010 at 12:01:51PM -0500, Ben Walton wrote:

Excerpts from Gary V. Vaughan's message of Thu Mar 11 11:27:50 -0500 2010:

quoted

-gitexecdir = libexec/git-core
+gitexecdir = libexec

You're proposing to change the execdir?

From the OP:

  This patch is in part to deal with peculiarities of our build                 
  environment [[...]] Probably, much of this patch is useful upstream.

We install each package in it's own directory, and remove redundant
directories as a local policy.  So /opt/fsw/git17/libexec/git-core
becomes /opt/fsw/git17/libexec.

My employer kindly agreed to donate a little of my paid time to push
the git patches we require to build on our supported hosts back
upstream.  There is certainly some good stuff in here that is useful
outside of our environment, but I have another 1600 packages to port
too...

Cheers,
    Gary
-- 
Gary V. Vaughan (gary@thewrittenword.com)

Heya,

On Fri, Mar 12, 2010 at 07:23, Gary V. Vaughan
[off-list ref] wrote:

My employer kindly agreed to donate a little of my paid time to push
the git patches we require to build on our supported hosts back
upstream.  There is certainly some good stuff in here that is useful
outside of our environment, but I have another 1600 packages to port
too...

While understandable, I hope your employer also understands that just
dumping a large patch upstream and tell them "have fun with it" does
not a good open source contribution make? Consider the time balance:
the investment required for us to figure out whether this patch is any
good for git, (not being familiar with the changes you're introducing,
and probably unable to test them since we lack the setup), and the
time it will cost you to split up the patches into an easily
reviewable series. I hope you (and your employer?) will agree that
it'd be less time for you to do so, than for us :).

Of course, if your employer is more like "pointy-haired boss" there's
not much you can do either.

-- 
Cheers,

Sverre Rabbelier