Re: [PATCH 00/12] Support columinized output in tag/branch/ls-files/grep

René Scharfe [off-list ref] writes:

Am 07.03.2010 13:09, schrieb Nguyễn Thái Ngọc Duy:

quoted

This adds support to show columnized output in the mentioned commands.

That's a good idea.

I'm not so sure about the interface, though.  Does the task really
warrant adding a new git command?

If a --column parameter is added, I think it should expose the full
range of options, i.e. fill columns first (ls -C style), fill rows first
(ls -x style) as well as off (ls -1 style) and auto.

Shouldn't the columnizer use utf8_width() instead of strlen(), like
strbuf_add_wrapped_text() in utf8.c?

I agree with all the above.  Also I think it should not be able to change
the behaviour of these commands so much without being explicitly asked
from the command line, especially for plumbing commands like ls-files.
IOW, introduction of the configuration variable without thinking things
through is a bad idea.

On Tue, Mar 9, 2010 at 6:08 AM, Junio C Hamano [off-list ref] wrote:

Also I think it should not be able to change
the behaviour of these commands so much without being explicitly asked
from the command line, especially for plumbing commands like ls-files.
IOW, introduction of the configuration variable without thinking things
through is a bad idea.

Hmm.. ls-files does not take core.columns into account. Command line
parameter --columns is the only way to turn column layout on in
ls-files.
-- 
Duy