git stash save <message>

Where can I find information about what content in <message> is (not)
allowed? We've got a bug-report where a SmartGit user has simply entered a
minus and Git refused to work. Of course, entering just a minus is quite
useless, but we have to be able to reliable detect allowed and disallowed
messages. Should every message with a leading minus be rejected? Maybe the
best would be to add a new command line option, e.g. --message before the
<message>, so one can provide anything as message?

--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com

Thomas Singer schrieb:

Where can I find information about what content in <message> is (not)
allowed? We've got a bug-report where a SmartGit user has simply entered a
minus and Git refused to work. Of course, entering just a minus is quite
useless, but we have to be able to reliable detect allowed and disallowed
messages.

Does SmartGit call 'git stash save' behind the scenes with the
user-supplied message? Then it should run

  git stash save -- "$msg"

and you don't need to forbid anything.

-- Hannes

On 05.03.2010 13:55, Johannes Sixt wrote:

Does SmartGit call 'git stash save' behind the scenes with the
user-supplied message? Then it should run

  git stash save -- "$msg"

and you don't need to forbid anything.

Thank you very much, this solved the problem.

Tom

Signed-off-by: Matthieu Moy <redacted>
---

quoted

Does SmartGit call 'git stash save' behind the scenes with the
user-supplied message? Then it should run

  git stash save -- "$msg"

and you don't need to forbid anything.

Thank you very much, this solved the problem.

... unless one considers that the problem is that you had to ask.
Something like this should avoid others the problem.

 git-stash.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-stash.sh b/git-stash.sh
index 2d69196..cf4e673 100755
--- a/git-stash.sh
+++ b/git-stash.sh

@@ -151,6 +151,7 @@ save_stash () {
 			;;
 		-*)
 			echo "error: unknown option for 'stash save': $1"
+			echo "       To provide a message, use 'git stash -- $1'."
 			usage
 			;;
 		*)

-- 
1.7.0.231.g9fa6.dirty

On Fri, Mar 05, 2010 at 05:14:53PM +0100, Matthieu Moy wrote:

Don't you mean "git stash save -- $1"?

-Peff

Signed-off-by: Matthieu Moy <redacted>
---
Oups, as noticed by peff, my proposed command was wrong ...

 git-stash.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-stash.sh b/git-stash.sh
index 2d69196..aa47e54 100755
--- a/git-stash.sh
+++ b/git-stash.sh

@@ -151,6 +151,7 @@ save_stash () {
 			;;
 		-*)
 			echo "error: unknown option for 'stash save': $1"
+			echo "       To provide a message, use git stash save -- '$1'"
 			usage
 			;;
 		*)

-- 
1.7.0.231.g9fa6.dirty