Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:21

Johannes Sixt [off-list ref] writes:

quoted hunk

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index 90178f9..37b9687 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh

@@ -8,6 +8,7 @@ test_description='Test commit notes'
 . ./test-lib.sh

 cat > fake_editor.sh << \EOF
+#!/bin/sh
 echo "$MSG" > "$1"
 echo "$MSG" >& 2
 EOF

Thanks.

Shouldn't that be "#!$SHELL_PATH", though?

Re: [PATCH jh/notes] t3301-notes: insert a shbang line in ./fake_editor.sh

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:48:21

Junio C Hamano schrieb:

Shouldn't that be "#!$SHELL_PATH", though?

It doesn't matter, but the change would be larger because we do not
want to expand $MSG.

-- Hannes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help