[PATCH] notes: fix malformed tree entry

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] notes: fix malformed tree entry

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:21

The mode bits for entries in a tree object should be an octal number
with minimum number of digits.  Do not pad it with 0 to the left.

Signed-off-by: Junio C Hamano <redacted>
---
 * This comes from 61a7cca (Notes API: write_notes_tree(): Store the notes
   tree in the database, 2010-02-13)

 notes.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/notes.c b/notes.c
index 3ba3e6d..a4f9926 100644
--- a/notes.c
+++ b/notes.c
@@ -624,8 +624,8 @@ static void write_tree_entry(struct strbuf *buf, unsigned int mode,
 		const char *path, unsigned int path_len, const
 		unsigned char *sha1)
 {
-		strbuf_addf(buf, "%06o %.*s%c", mode, path_len, path, '\0');
-		strbuf_add(buf, sha1, 20);
+	strbuf_addf(buf, "%o %.*s%c", mode, path_len, path, '\0');
+	strbuf_add(buf, sha1, 20);
 }
 
 static void tree_write_stack_init_subtree(struct tree_write_stack *tws,
-- 
1.7.0.227.g2f3f2

Re: [PATCH] notes: fix malformed tree entry

From: Johan Herland <hidden>
Date: 2016-06-15 22:48:21

On Thursday 25 February 2010, Junio C Hamano wrote:
The mode bits for entries in a tree object should be an octal number
with minimum number of digits.  Do not pad it with 0 to the left.

Signed-off-by: Junio C Hamano <redacted>
Acked-by: Johan Herland <redacted>

-- 
Johan Herland, [off-list ref]
www.herland.net
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help