Steven Drake [off-list ref] writes:
Has the same functionality as the '--cc' option and 'format.cc'
configuration variable but for the "To:" email header. Half of the code to
support this was already there.
I don't _mind_ adding such a config (I didn't check the patch text,
though), but one thing I don't understand is what kind of workflow do
people who use format.cc, format.to, --cc and --to are using.
My impression has always been that you drive your _MUA_ to set these
values, and MUAs are either (1) not so cooperating to read these headers
from format-patch output and use them to decide where to send mails from,
or (2) is a git-send-email which is customizable already per repository so
you do not have to do anything funky when running format-patch.
How are you sending your output from format-patch, and how does having To:
and Cc: header pregenerated by format-patch help you?
On Tue, 16 Feb 2010, Junio C Hamano wrote:
I don't _mind_ adding such a config (I didn't check the patch text,
though), but one thing I don't understand is what kind of workflow do
people who use format.cc, format.to, --cc and --to are using.
In the commit that add '--cc', Daniel Barkalow wrote:
When you have particular reviewers you want to sent particular series
to, it's nice to be able to generate the whole series with them as
additional recipients, without configuring them into your general
headers or adding them by hand afterwards.
In the commit that added 'format.cc' Miklos Vajna wrote:
Some projects prefer to always CC patches to a given mailing list. In
these cases, it's handy to configure that address once.
I think it's weired to have an option & config variable for Cc and not To.
My impression has always been that you drive your _MUA_ to set these
values, and MUAs are either (1) not so cooperating to read these headers
from format-patch output and use them to decide where to send mails from,
Any MUA that does not cooperate with reading the To header is going to
give trouble with any header (e.g. Subject, Date).
or (2) is a git-send-email which is customizable already per repository so
you do not have to do anything funky when running format-patch.
Haven't got around to using git-send-email yet!
[...] how does having To:
and Cc: header pregenerated by format-patch help you?
Mostly having to remember/lookup the email address.
--
Steven
Junio C Hamano:
How are you sending your output from format-patch, and how does having To:
and Cc: header pregenerated by format-patch help you?
The patches I have sent to the list have all been sent using
git format-patch something
$EDITOR *.patch # remove mbox header, and add To:
for file in *.patch ; do sendmail -t < $file ; done
as every attempt I have done to send them through Alpine or other MUAs have
failed horribly.
I haven't minded having to edit the patch files manually (since I have also
visually inspected the patch files in the process), but being able to add
the To: line for the list automatically for each of the patches lessens the
risk of misspelling or missing it completely when fixing the patches up.
--
\\// Peter - http://www.softwolves.pp.se/