Re: [PATCH] git-gui: use themed tk widgets with Tk 8.5

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] git-gui: use themed tk widgets with Tk 8.5

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:48:07

"Shawn O. Pearce" [off-list ref] writes:
Johannes Schindelin [off-list ref] wrote:
quoted
On Wed, 27 Jan 2010, Shawn O. Pearce wrote:
quoted
Pat Thoyts [off-list ref] wrote:
quoted
This patch enables the use of themed Tk widgets with Tk 8.5 and above.
...
quoted
quoted
Thanks.  I've been running with this pretty much all day today;
it seems sane.  I'll probably push it shortly.
Thanks.  Can you notify me when you do so?  I will merge into 4msysgit.git 
directly then.
Its already there.
Is that an insn for me to pull?

Re: [PATCH] git-gui: use themed tk widgets with Tk 8.5

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:48:07

Junio C Hamano [off-list ref] wrote:
"Shawn O. Pearce" [off-list ref] writes:
quoted
Johannes Schindelin [off-list ref] wrote:
quoted
On Wed, 27 Jan 2010, Shawn O. Pearce wrote:
quoted
Pat Thoyts [off-list ref] wrote:
quoted
This patch enables the use of themed Tk widgets with Tk 8.5 and above.
...
quoted
quoted
Thanks.  I've been running with this pretty much all day today;
it seems sane.  I'll probably push it shortly.
Thanks.  Can you notify me when you do so?  I will merge into 4msysgit.git 
directly then.
Its already there.
Is that an insn for me to pull?
You can pull my master branch if you like; though I wouldn't suggest
it for anything other than 'next' yet:


The following changes since commit 87cd09f43e56de5235d09aef3ff5d840419fef49:
  Giuseppe Bilotta (1):
        git-gui: work from the .git dir

are available in the git repository at:

  git://git.spearce.org/git-gui.git master

Christian Stimming (1):
      git-gui: Update German translation (12 new or changed strings).

Giuseppe Bilotta (4):
      git-gui: handle non-standard worktree locations
      git-gui: handle bare repos correctly
      git-gui: update shortcut tools to use _gitworktree
      git-gui: set GIT_DIR and GIT_WORK_TREE after setup

Jeff Epler (1):
      git-gui: Support applying a range of changes at once

Jens Lehmann (2):
      git-gui: Use git diff --submodule when available
      git-gui: Add a special diff popup menu for submodules

Pat Thoyts (1):
      git-gui: use themed tk widgets with Tk 8.5

Peter Oberndorfer (1):
      git-gui: use different icon for new and modified files in the index

Shawn O. Pearce (2):
      git-gui: Remove unused icon file_parttick
      git-gui: Update translation template

 git-gui.sh                   |  397 +++++++++++++++------
 lib/about.tcl                |   37 +--
 lib/blame.tcl                |   22 +-
 lib/branch_checkout.tcl      |   20 +-
 lib/branch_create.tcl        |   45 ++--
 lib/branch_delete.tcl        |   24 +-
 lib/branch_rename.tcl        |   32 +-
 lib/browser.tcl              |   41 ++-
 lib/choose_font.tcl          |   31 +-
 lib/choose_repository.tcl    |   94 +++---
 lib/choose_rev.tcl           |   51 ++--
 lib/class.tcl                |    7 +
 lib/console.tcl              |   17 +-
 lib/database.tcl             |   20 +-
 lib/diff.tcl                 |  259 ++++++++------
 lib/error.tcl                |   15 +-
 lib/index.tcl                |   13 +-
 lib/merge.tcl                |   14 +-
 lib/option.tcl               |   67 ++--
 lib/remote_add.tcl           |   37 +-
 lib/remote_branch_delete.tcl |   51 ++--
 lib/search.tcl               |   11 +-
 lib/shortcut.tcl             |    7 +-
 lib/sshkey.tcl               |   20 +-
 lib/status_bar.tcl           |   14 +-
 lib/themed.tcl               |  174 +++++++++
 lib/tools_dlg.tcl            |   87 ++---
 lib/transport.tcl            |   48 ++--
 po/de.po                     |  824 ++++++++++++++++++++++--------------------
 po/git-gui.pot               |  584 +++++++++++++++--------------
 30 files changed, 1772 insertions(+), 1291 deletions(-)
 create mode 100644 lib/themed.tcl

-- 
Shawn.

[PATCH] git gui: Quote git path properly when starting another gui in a submodule

From: Jens Lehmann <hidden>
Date: 2016-06-15 22:48:07

In do_git_gui() the path of the git executable has to be put into a list,
otherwise calling it will fail when when spaces are present in its path.

Reported-by: Heiko Voigt <redacted>
Signed-off-by: Jens Lehmann <redacted>
---


Am 28.01.2010 03:56, schrieb Shawn O. Pearce:
Jens Lehmann (2):
      git-gui: Use git diff --submodule when available
      git-gui: Add a special diff popup menu for submodules
Today Heiko reported me this bug I introduced with the second patch.
Sorry for the hassle.


 git-gui/git-gui.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index a64191d..840f45c 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -2000,7 +2000,7 @@ proc do_git_gui {} {
 	# -- Always start git gui through whatever we were loaded with.  This
 	#    lets us bypass using shell process on Windows systems.
 	#
-	set exe [_which git]
+	set exe [list [_which git]]
 	if {$exe eq {}} {
 		error_popup [mc "Couldn't find git gui in PATH"]
 	} else {
-- 
1.7.0.rc0.163.g808df.dirty

Re: [PATCH] git gui: Quote git path properly when starting another gui in a submodule

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:48:07

Jens Lehmann [off-list ref] wrote:
In do_git_gui() the path of the git executable has to be put into a list,
otherwise calling it will fail when when spaces are present in its path.

Reported-by: Heiko Voigt <redacted>
Signed-off-by: Jens Lehmann <redacted>
---


Am 28.01.2010 03:56, schrieb Shawn O. Pearce:
quoted
Jens Lehmann (2):
      git-gui: Use git diff --submodule when available
      git-gui: Add a special diff popup menu for submodules
Today Heiko reported me this bug I introduced with the second patch.
Sorry for the hassle.
Applied, thanks.
 
-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help