Johannes Schindelin [off-list ref] writes:
On Mon, 11 Jan 2010, Thiago Farina wrote:
quoted
Signed-off-by: Thiago Farina <redacted>
---
It was never used, except for debugging. Does it hurt you really all that
much?
Exactly my feeling.
I think I discarded at least two other patches sent to me to remove this
"unused" (but obviously meant for debugging) function in the past. I
guess we'll keep the function this time, too.
On Mon, 11 Jan 2010, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
On Mon, 11 Jan 2010, Thiago Farina wrote:
quoted
Signed-off-by: Thiago Farina <redacted>
---
It was never used, except for debugging. Does it hurt you really all that
much?
Exactly my feeling.
I think I discarded at least two other patches sent to me to remove this
"unused" (but obviously meant for debugging) function in the past. I
guess we'll keep the function this time, too.
If so many people are so inclined to discard it, then maybe a little
comment could be added to explain its existance?
Nicolas
On Mon, Jan 11, 2010 at 8:23 PM, Nicolas Pitre [off-list ref] wrote:
On Mon, 11 Jan 2010, Junio C Hamano wrote:
quoted
Johannes Schindelin [off-list ref] writes:
quoted
On Mon, 11 Jan 2010, Thiago Farina wrote:
quoted
Signed-off-by: Thiago Farina <redacted>
---
It was never used, except for debugging. Does it hurt you really all that
much?
Exactly my feeling.
I think I discarded at least two other patches sent to me to remove this
"unused" (but obviously meant for debugging) function in the past. I
guess we'll keep the function this time, too.
If so many people are so inclined to discard it, then maybe a little
comment could be added to explain its existance?
I can add the comment if Junio is ok with it. Something like this:
"This functions is for debugging purpose only. Please, do NOT remove
it."