Filename quoting / parsing problem
From: Andreas Gruenbacher <hidden>
Date: 2016-06-15 22:47:57
Git quotes file names as documented in the git-diff manual page:
TAB, LF, double quote and backslash characters in pathnames are represented
as \t, \n, \" and \\, respectively. If there is need for such substitution
then the whole pathname is put in double quotes.
Spaces in file names currently do not trigger quoting. (And \r triggers
quoting even though the man page doesn't say so). When there are no "---" and
"+++" lines, this can lead to a parsing problem: only the "diff --git" line
contains the file names, sometimes with insufficient quoting. The following
examples show the problem:
Parseable:
diff --git "a/foo \r" "b/foo \r"
new file mode 100644
index 0000000..257cc56
--- /dev/null
+++ "b/foo \r"
@@ -0,0 +1 @@
+foo
Parseable:
diff --git a/bar b/bar
new file mode 100644
index 0000000..5716ca5
--- /dev/null
+++ b/bar
@@ -0,0 +1 @@
+bar
Not parseable:
diff --git a/baz b/baz
new file mode 100644
index 0000000..e69de29
Could this please be changed so that filenames with spaces are also quoted, at
least in the "diff --git" line, and possibly also in the "---" and "+++"
lines? Alternatively, how about a new extended header with the file name in
this particular case?
Thanks,
Andreas