Re: [PATCH/RFC] ignore unknown color configuration

Junio C Hamano [off-list ref] writes:

Jeff King [off-list ref] writes:

quoted

On Sat, Dec 12, 2009 at 01:45:45PM -0800, Junio C Hamano wrote:

quoted

This is a sane thing to do, as "slot" is part of the name of the variable,
and we generally do not warn upon seeing a misspelled variable name (it
makes it worse that "func" is not even misspelled but merely unknown to
older version of git in your scenario).

On the other hand, I suspect that most people would apprecfiate if their
git pointed out "diff.color.finc?  What do you mean?"  before they waste
30 minutes wondering why the new feature in 1.6.6 does not work for them.

I would be more sympathetic to that user if this weren't the _only_ set
of variables with this property. They don't get warned for diff.externel
or color.show-branch.

True and fair enough.  Let's have this in 1.6.6 then.

Actually I think we should have this in 1.6.5.X as well for it to be
useful.  Am I mistaken?

On Tue, Dec 15, 2009 at 05:25:36PM -0800, Junio C Hamano wrote:

quoted

quoted

I would be more sympathetic to that user if this weren't the _only_ set
of variables with this property. They don't get warned for diff.externel
or color.show-branch.

True and fair enough.  Let's have this in 1.6.6 then.

Actually I think we should have this in 1.6.5.X as well for it to be
useful.  Am I mistaken?

The earlier the better for making it useful, but it is still somewhat of
a lost cause for color.diff.func. The problem comes from using git
v1.6.6, setting the variable, and then going to back to some older
version (either because you are testing multiple versions, or because
your config is shared across multiple machines).

So yes, putting it in v1.6.5.x means switching back there will not be as
painful. But switching back to existing versions will still be broken
until all older versions you might want to switch to have this patch.

So we are not so much fixing this color.diff.func problem as
future-proofing against this happening again.

-Peff