Re: [PATCH] tests: handle NO_PYTHON setting

Sverre Rabbelier [off-list ref] writes:

On Mon, Nov 30, 2009 at 08:59, Jeff King [off-list ref] wrote:

quoted

I mean, I would think that the "git_remote_helpers" directory contained
remote helpers of all sorts, not just the python ones.

I don't think that's true, git.git currently does not have such a
structure (everything is just dumped in the root directory). The only
reason git_remote_helpers exists is to make it easier to create a
python egg out of it and install that.

If that is the case, shouldn't each of the helper written in Python need
to have a separate directory, not just a single git_remote_helpers
directory shared among them?

Heya,

On Mon, Nov 30, 2009 at 09:28, Junio C Hamano [off-list ref] wrote:

Sverre Rabbelier [off-list ref] writes:

quoted

I don't think that's true, git.git currently does not have such a
structure (everything is just dumped in the root directory). The only
reason git_remote_helpers exists is to make it easier to create a
python egg out of it and install that.

If that is the case, shouldn't each of the helper written in Python need
to have a separate directory, not just a single git_remote_helpers
directory shared among them?

I don't understand why that would be needed? The reason we added a
single git_remote_helpers directory is because we wanted to share
common code, having a single python package makes that easy.

-- 
Cheers,

Sverre Rabbelier