Re: [PATCH 1/7] Refactor git_remote_cvs to a more generic git_remote_helpers

On Thursday 29 October 2009, Sverre Rabbelier wrote:

This in an effort to allow future remote helpers written in python to
re-use the non-cvs-specific code.

Signed-off-by: Sverre Rabbelier <redacted>
CC: Johan Herland <redacted>
---

	As discussed with Johan Herland, refactored git_remote_cvs into a
	more reusable git_remote_helpers module.

It's hard to review this patch for a couple of reasons:

1. It's over 200K large, which causes it to be blocked by the Git mailing 
list (100K limit, I believe).

2. The patch renames some files, but instead of simply stating the rename, 
the patch lists the entire file twice (deletion + creation)

Fortunately, you can easily solve both problems by rerolling the patch with 
the -M flag to git-format-patch.


...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net

Heya,

On Thu, Oct 29, 2009 at 05:05, Johan Herland [off-list ref] wrote:

Fortunately, you can easily solve both problems by rerolling the patch with
the -M flag to git-format-patch.

Whow, I feel really silly now, thanks for pointing that out, proper patch sent!

-- 
Cheers,

Sverre Rabbelier