2 messages, 2 authors, 2016-06-15 · open the first message on its own page
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:47:35
Matt Kraai [off-list ref] writes:
Do not check whether PERL_PATH and SHELL_PATH are undefined before setting their default values. This prevents them from being set via environment variables.
Is there an upside of "preventing them from getting set", by the way?
From: Matt Kraai <hidden>
Date: 2016-06-15 22:47:35
On Tue, Oct 20, 2009 at 09:18:29AM -0700, Junio C Hamano wrote:
Matt Kraai [off-list ref] writes:quoted
Do not check whether PERL_PATH and SHELL_PATH are undefined before setting their default values. This prevents them from being set via environment variables.Is there an upside of "preventing them from getting set", by the way?
Not that I know of. I originally thought that the checks were superfluous, but now I just believe they're inconsistent and confusing to people like me who think they understand Makefiles but don't. :) -- Matt Kraai http://ftbfs.org/