[PATCH 3/8] Use a function to determine whether a remote is valid
From: Daniel Barkalow <hidden>
Date: 2016-06-15 22:47:21
Subsystem:
the rest · Maintainer:
Linus Torvalds
Currently, it only checks url, but it will allow other things in the future. Signed-off-by: Daniel Barkalow <redacted> --- remote.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/remote.c b/remote.c
index 4b5b905..fec63fa 100644
--- a/remote.c
+++ b/remote.c@@ -48,6 +48,11 @@ static int rewrite_nr; #define BUF_SIZE (2048) static char buffer[BUF_SIZE]; +static int valid_remote(const struct remote *remote) +{ + return !!remote->url; +} + static const char *alias_url(const char *url) { int i, j;
@@ -667,14 +672,14 @@ struct remote *remote_get(const char *name) ret = make_remote(name, 0); if (valid_remote_nick(name)) { - if (!ret->url) + if (!valid_remote(ret)) read_remotes_file(ret); - if (!ret->url) + if (!valid_remote(ret)) read_branches_file(ret); } - if (name_given && !ret->url) + if (name_given && !valid_remote(ret)) add_url_alias(ret, name); - if (!ret->url) + if (!valid_remote(ret)) return NULL; ret->fetch = parse_fetch_refspec(ret->fetch_refspec_nr, ret->fetch_refspec); ret->push = parse_push_refspec(ret->push_refspec_nr, ret->push_refspec);
--
1.6.4.2.419.gc86f8