[PATCH] Fix typo in filter-branch example

Subsystems: documentation, the rest

DORMANTno replies

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

[PATCH] Fix typo in filter-branch example

From: Ori Avtalion <hidden>
Date: 2016-06-15 22:47:14

---
 Documentation/git-filter-branch.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index ab527b5..8cda87c 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -336,7 +336,7 @@ To move the whole tree into a subdirectory, or remove it from there:
 
 ---------------------------------------------------------------
 git filter-branch --index-filter \
-	'git ls-files -s | sed "s-\t-&newsubdir/-" |
+	'git ls-files -s | sed "s-\t-\tnewsubdir/-" |
 		GIT_INDEX_FILE=$GIT_INDEX_FILE.new \
 			git update-index --index-info &&
 	 mv $GIT_INDEX_FILE.new $GIT_INDEX_FILE' HEAD
-- 
1.6.4.114.gefd1.dirty

Re: [PATCH] Fix typo in filter-branch example

From: Michael J Gruber <hidden>
Date: 2016-06-15 22:47:14

Ori Avtalion venit, vidit, dixit 13.08.2009 18:16:
quoted hunk
---
 Documentation/git-filter-branch.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index ab527b5..8cda87c 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -336,7 +336,7 @@ To move the whole tree into a subdirectory, or remove it from there:
 
 ---------------------------------------------------------------
 git filter-branch --index-filter \
-	'git ls-files -s | sed "s-\t-&newsubdir/-" |
+	'git ls-files -s | sed "s-\t-\tnewsubdir/-" |
 		GIT_INDEX_FILE=$GIT_INDEX_FILE.new \
 			git update-index --index-info &&
 	 mv $GIT_INDEX_FILE.new $GIT_INDEX_FILE' HEAD
If \t is matched then isn't & == \t?

Michael

Re: [PATCH] Fix typo in filter-branch example

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:47:14

Hi,

On Thu, 13 Aug 2009, Ori Avtalion wrote:
---
This is not a typo. '&' is sed's way to specify the matched string.  Where 
does it occur anyway (the commit message makes a fabulous place to put 
such information)?

Ciao,
Dscho

Re: [PATCH] Fix typo in filter-branch example

From: Ori Avtalion <hidden>
Date: 2016-06-15 22:47:14

On 08/13/2009 08:04 PM, Johannes Schindelin wrote:
This is not a typo. '&' is sed's way to specify the matched string.  Where
does it occur anyway (the commit message makes a fabulous place to put
such information)?
Whoops! My mistake!

I think I accidentally removed it when I tried the example, and then 
added it in a wrong position when that didn't work :)

Sorry for the false alarm!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help