Re: [PATCH] request-pull: do not paginate output of git commands

Junio C Hamano [off-list ref] writes:

Michal Marek [off-list ref] writes:

quoted

git request-pull called inside a terminal prints part of the output to
the terminal and other parts are piped through the pager. Fix this.

Hmph, I have always thought this was meant to be a feature.

That is, you run it to yourself, instead of piping it to a file or "| mail
torvalds", in order to sanity check before you actually do the latter.
When the request is larger than a screenful, you would want a pager while
reviewing.

Sorry, I take it back.

If it _were_ a single call to a paging command what I said may make sense,
but with many separate calls to shortlog, we wouldn't know which output is
too large (and uses pager).  I agree your patch makes things better.

I should have read your commit log message after finishing my coffee ;-)

Thanks.

Junio C Hamano napsal(a):

Junio C Hamano [off-list ref] writes:

quoted

Michal Marek [off-list ref] writes:

quoted

git request-pull called inside a terminal prints part of the output to
the terminal and other parts are piped through the pager. Fix this.

Hmph, I have always thought this was meant to be a feature.

That is, you run it to yourself, instead of piping it to a file or "| mail
torvalds", in order to sanity check before you actually do the latter.
When the request is larger than a screenful, you would want a pager while
reviewing.

Sorry, I take it back.

If it _were_ a single call to a paging command what I said may make sense,
but with many separate calls to shortlog, we wouldn't know which output is
too large (and uses pager).  I agree your patch makes things better.

Yes, this is what I dislike, it prints parts to the terminal and parts
are paged (separately). Paging the whole output would be a nice
improvement, but probably not worth the effort.

I should have read your commit log message after finishing my coffee ;-)

:-)

Michal