Re: [PATCHv4 0/2] gitweb: gravatar support

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCHv4 0/2] gitweb: gravatar support

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:59

Giuseppe Bilotta [off-list ref] writes:
As suggested by Junio, the author display refactoring now comes before
the actual gravatar feature implementation. The refactoring also goes a
little bit deeper, changing the 'commitdiff' view to match 'commit' for
the author and committer layout.

Giuseppe Bilotta (2):
  gitweb: refactor author name insertion
  gitweb: gravatar support

 gitweb/gitweb.css  |    9 +++-
 gitweb/gitweb.perl |  123 ++++++++++++++++++++++++++++++++++++++-------------
 2 files changed, 99 insertions(+), 33 deletions(-)
Thanks.  It looks much better for reviewing, now the order of the patches
are sane.

Does anybody have comments on the patches?

Re: [PATCHv4 0/2] gitweb: gravatar support

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:46:59

Junio C Hamano wrote:
Giuseppe Bilotta [off-list ref] writes:
quoted
As suggested by Junio, the author display refactoring now comes before
the actual gravatar feature implementation. The refactoring also goes a
little bit deeper, changing the 'commitdiff' view to match 'commit' for
the author and committer layout.

Giuseppe Bilotta (2):
  gitweb: refactor author name insertion
  gitweb: gravatar support

 gitweb/gitweb.css  |    9 +++-
 gitweb/gitweb.perl |  123 ++++++++++++++++++++++++++++++++++++++-------------
 2 files changed, 99 insertions(+), 33 deletions(-)
Thanks.  It looks much better for reviewing, now the order of the patches
are sane.

Does anybody have comments on the patches?
I'll send my comments today.

-- 
Jakub Narebski
Poland

Re: [PATCHv4 0/2] gitweb: gravatar support

From: Nanako Shiraishi <hidden>
Date: 2016-06-15 22:46:59

Quoting Junio C Hamano [off-list ref]:
Thanks.  It looks much better for reviewing, now the order of the patches
are sane.

Does anybody have comments on the patches?
I'll send my comments later today.

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help