Re: [PATCH] send-email: Refuse to send cover-letter template subject

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] send-email: Refuse to send cover-letter template subject

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:56

Markus Heidelberg [off-list ref] writes:
quoted
Good ;-).  More valuable to detect would be an empty "blurb" section
(i.e. not "unedited *** BLURB HERE ***" string, but literally, there is
nothing said in the message other than the shortstat).
My mail "[PATCH 0/6] fixes for git-send-email" had an empty blurb
section because it didn't need any additional description.
I wouldn't want git to refuse sending it.
I actually wouldn't have wanted to see that [0/6] with empty description.

If the list of 6 patch titles give clear enough description of the theme
of the whole series, you would not need [0/6] to set the stage, and that
is the best kind of series.  For your send-email patches, you certainly
chose very good titles for them.

Re: [PATCH] send-email: Refuse to send cover-letter template subject

From: Markus Heidelberg <hidden>
Date: 2016-06-15 22:46:56

Junio C Hamano, 09.06.2009:
Markus Heidelberg [off-list ref] writes:
quoted
My mail "[PATCH 0/6] fixes for git-send-email" had an empty blurb
section because it didn't need any additional description.
I wouldn't want git to refuse sending it.
I actually wouldn't have wanted to see that [0/6] with empty description.
I thought the diffstat is a nice overview as well. So there is at least
some value in a blurb-less cover letter. But I guess they are debatable.
If the list of 6 patch titles give clear enough description of the theme
of the whole series, you would not need [0/6] to set the stage,
I prefer --thread --no-chain-reply-to for more than 2 patches, so it
seems I sometimes only abuse the 0/X as a common anchor for 1..X/X. I'd
find it strange to use 1/X for that.
and that is the best kind of series.
Hmm, so then you prefer no 0/X at all.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help