DORMANTno replies

[PATCH] builtin-remote: Make "remote show" display all urls

From: Michael J Gruber <hidden>
Date: 2016-06-15 22:46:55
Subsystem: the rest · Maintainer: Linus Torvalds

Currently, "git remote -v" lists all urls whereas "git remote show
$remote" shows only the first. Make it so that both show all.

Signed-off-by: Michael J Gruber <redacted>
---
While looking around what I need to change in builtin-remote.c for the pushurls
I noticed the above asymmetric behaviour. While I'm not sure what multiple urls
are good for (as far as fetches are concerned) I think we should still show them
(they may all be used for push).

This is on top of maint.

 builtin-remote.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index fda9a54..d436412 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -1003,9 +1003,12 @@ static int show(int argc, const char **argv)
 
 		get_remote_ref_states(*argv, &states, query_flag);
 
-		printf("* remote %s\n  URL: %s\n", *argv,
-			states.remote->url_nr > 0 ?
-				states.remote->url[0] : "(no URL)");
+		printf("* remote %s\n", *argv);
+		if (states.remote->url_nr) {
+			for (i=0; i < states.remote->url_nr; i++)
+				printf("  URL: %s\n", states.remote->url[i]);
+		} else
+			printf("  URL: %s\n", "(no URL)");
 		if (no_query)
 			printf("  HEAD branch: (not queried)\n");
 		else if (!states.heads.nr)
-- 
1.6.3.2.277.gd10543
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help