[PATCH QGit 1/4] Don't count the submenu entries for checking if it is empty
From: Markus Heidelberg <hidden>
Date: 2016-06-15 22:46:54
Subsystem:
the rest · Maintainer:
Linus Torvalds
Checking with isEmpty() is more effective. Signed-off-by: Markus Heidelberg <redacted> --- src/mainimpl.cpp | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mainimpl.cpp b/src/mainimpl.cpp
index 8c7b19e..60414ab 100644
--- a/src/mainimpl.cpp
+++ b/src/mainimpl.cpp@@ -1179,7 +1179,7 @@ void MainImpl::doContexPopup(SCRef sha) { act = contextRmtMenu.addAction(*it); act->setData("Ref"); } - if (contextRmtMenu.actions().count() > 0) + if (!contextRmtMenu.isEmpty()) contextMenu.addMenu(&contextRmtMenu); if (!bn.empty())
@@ -1194,7 +1194,7 @@ void MainImpl::doContexPopup(SCRef sha) { act->setData("Ref"); } if (!tn.empty()) - if (contextSubMenu.actions().count() > 0) + if (!contextSubMenu.isEmpty()) contextSubMenu.addSeparator(); else contextMenu.addSeparator();
@@ -1207,7 +1207,7 @@ void MainImpl::doContexPopup(SCRef sha) { act->setData("Ref"); } - if (contextSubMenu.actions().count() > 0) + if (!contextSubMenu.isEmpty()) contextMenu.addMenu(&contextSubMenu); } contextMenu.exec(QCursor::pos());
--
1.6.3.2.213.g30b07