[PATCH 18/23] http-push.c::remote_exists(): use the new http API

From:	Mike Hommey <redacted>
Subject: [WIP Patch 08/12] Use the new http API in update_remote_info_refs()
Date:	Sun, 18 Jan 2009 09:04:33 +0100

Signed-off-by: Mike Hommey <redacted>
Signed-off-by: Tay Ray Chuan <redacted>
---
 http-push.c |   31 ++++++++++++-------------------
 1 files changed, 12 insertions(+), 19 deletions(-)

diff --git a/http-push.c b/http-push.c
index b01db75..455e0aa 100644
--- a/http-push.c
+++ b/http-push.c

@@ -2005,29 +2005,22 @@ static void update_remote_info_refs(struct remote_lock *lock)
 static int remote_exists(const char *path)
 {
 	char *url = xmalloc(strlen(repo->url) + strlen(path) + 1);
-	struct active_request_slot *slot;
-	struct slot_results results;
-	int ret = -1;
+	int ret;

 	sprintf(url, "%s%s", repo->url, path);

-	slot = get_active_slot();
-	slot->results = &results;
-	curl_easy_setopt(slot->curl, CURLOPT_URL, url);
-	curl_easy_setopt(slot->curl, CURLOPT_NOBODY, 1);
-
-	if (start_active_slot(slot)) {
-		run_active_slot(slot);
-		if (results.http_code == 404)
-			ret = 0;
-		else if (results.curl_result == CURLE_OK)
-			ret = 1;
-		else
-			fprintf(stderr, "HEAD HTTP error %ld\n", results.http_code);
-	} else {
-		fprintf(stderr, "Unable to start HEAD request\n");
+	switch (http_get_strbuf(url, NULL, 0)) {
+	case HTTP_OK:
+		ret = 1;
+		break;
+	case HTTP_MISSING_TARGET:
+		ret = 0;
+		break;
+	case HTTP_ERROR:
+		http_error(url, HTTP_ERROR);
+	default:
+		ret = -1;
 	}
-
 	free(url);
 	return ret;
 }
--

1.6.3.1

Tay Ray Chuan [off-list ref] writes:

From:	Mike Hommey <redacted>
Subject: [WIP Patch 08/12] Use the new http API in update_remote_info_refs()

What is the subject of this patch:
  "http-push.c::remote_exists(): use the new http API"
or
  "Use the new http API in update_remote_info_refs()"?

Date:	Sun, 18 Jan 2009 09:04:33 +0100

Signed-off-by: Mike Hommey <redacted>
Signed-off-by: Tay Ray Chuan <redacted>

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Hi,

On Sat, Jun 6, 2009 at 4:54 AM, Jakub Narebski[off-list ref] wrote:

What is the subject of this patch:
 "http-push.c::remote_exists(): use the new http API"
or
 "Use the new http API in update_remote_info_refs()"?

See my reply to patch #19.

-- 
Cheers,
Ray Chuan